forked from MIT-SPARK/Kimera-VIO
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR3: Adding abstract class corresponding to OpenCvVisualizer3D and making other relevant changes #4
Open
sarika93
wants to merge
3
commits into
xcomp_refactor/add_colorutils
Choose a base branch
from
xcomp_refactor/vis_abstract_classes
base: xcomp_refactor/add_colorutils
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarika93
commented
Dec 12, 2024
@@ -51,7 +51,7 @@ class MeshOptimization { | |||
MeshOptimization(const MeshOptimizerType& solver_type, | |||
const MeshColorType& mesh_color_type, | |||
Camera::ConstPtr camera, | |||
OpenCvVisualizer3D::Ptr visualizer = nullptr); | |||
std::shared_ptr<VIO::BaseOpenCvVisualizer3D> visualizer = nullptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about format of the this, per Google C++ styleguide.
sarika93
commented
Dec 12, 2024
src/mesh/MeshOptimization.cpp
Outdated
@@ -50,7 +50,7 @@ constexpr float MeshOptimization::kMaxZ; | |||
MeshOptimization::MeshOptimization(const MeshOptimizerType& solver_type, | |||
const MeshColorType& mesh_color_type, | |||
Camera::ConstPtr camera, | |||
OpenCvVisualizer3D::Ptr visualizer) | |||
std::shared_ptr<VIO::BaseOpenCvVisualizer3D> visualizer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about format of the this, per Google C++ styleguide.
sarika93
requested review from
vpradeep07 and
shiv1994
and removed request for
vpradeep07,
shiv1994 and
enrique-ramkissoon
January 6, 2025 18:53
sarika93
changed the title
Adding abstract class corresponding to OpenCvVisualizer3D and making other relevant changes
PR3: Adding abstract class corresponding to OpenCvVisualizer3D and making other relevant changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third PR in a series of changes that aim to make building with the visualizer module optional and remove the cv::viz dependency from other modules. A key feature of this change is to utilize abstract classes to add dummy visualizer classes with stubbed out functions. These dummy classes can then be utilized when building without the visualizer. This change focuses on adding the
BaseOpenCvVisualizer
abstract class and updatingOpenCvVisualizer3D
to be derived from it. This class is used byMeshOptimization
andEurocPlayground
. The dummy class is not yet included, to simplify the PR.Changes include:
The follow up PR will have all other abstract classes, but submitting this one first to make sure the format of changes are reasonable.
Full design document can be found here.
Visualization Build Option Refactor for Kimera-VIO.pdf
Testing process
Build docker container for testing
Testing
Kimera-VIO/params/Euroc/flags/stereoVIOEuroc.flags
with your editor of choice and modify-- log_output
to true.-- log_output
to true.LOG_OUTPUT
variable from 0 to 1../stereoVIOEuroc.bash
.Then re-run Kimera-VIO as shown in step 2. You should be re-running with the same configuration options.
You should also be looking out for any differences in the visualizer behaviour.